makefiles/gnu.inc.mk: set flags based on compiler version #18935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
benpicco
force-pushed
the
makefiles/gnu-version
branch
from
ca5269c to
998c4e9
Compare
benpicco
added
the
CI: ready for build
maribu
reviewed
Nov 19, 2022
makefiles/toolchain/gnu.inc.mk
Outdated
| GCC_VERSION := $(shell $(CC) -dumpversion) | ||
|
|
||
| # -fmacro-prefix-map requires GCC 8 | ||
| ifneq (8, $(firstword $(shell echo "8\n$(GCC_VERSION)" | sort -V)))) |
There was a problem hiding this comment.
This is not portable, as replacing \n with a newline character is not POSIX standard. Bash will do so, but not e.g. ash. Also, -V seems not to not work with all implementations of sort.
There was a problem hiding this comment.
I hope it's portable now - is there an easy way to check this?
benpicco
force-pushed
the
makefiles/gnu-version
branch
from
998c4e9 to
b30efee
Compare
maribu
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
-fmacro-prefix-mapwas introduced in GCC 8, so only set it if the compiler version is 8 or newer.Testing procedure
Issues/PRs references
#18913 (comment)